Remove depreciated Hyrax::SolrQueryBuilderService from tests #6396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
previously approved these changes
Oct 26, 2023
no-reply
force-pushed
the
refector-SolrQuery-name-4946-tests
branch
from
e99fe7d to
b297f92
Compare
rawOrlando
force-pushed
the
refector-SolrQuery-name-4946-tests
branch
12 times, most recently
from
6c1f3e6 to
f6beb89
Compare
|
I have not figured out why the tests fail with these changes. It looks like the line I just wanted to let you know that I'm putting this work down for now. |
rawOrlando
force-pushed
the
refector-SolrQuery-name-4946-tests
branch
from
a3e78ce to
3f6d565
Compare
rawOrlando
force-pushed
the
refector-SolrQuery-name-4946-tests
branch
from
3f6d565 to
62e9dae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
refs #4946
Summary
Small piece of refactoring. Replace uses of deprecated Hyrax::SolrQueryBuilderService with Hyrax::SolrQueryService in spec.
Also I want to have a small PR under my belt to understand the community workflow
Testing
Test continue to pass
@samvera/hyrax-code-reviewers